Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an overlay[caller?] annotation to optimize the transitive closure computation in Java dataflow analysis by preventing materialization in overlay mode.
- Adds overlay[caller?] annotation to the
localFlowStepPluspredicate
Contributor
|
The DCA experiment shows unique alert query locations for source |
Contributor
Author
|
A similar change exists on a nightly from a couple of days ago as well, and it looks like an alert in a generated file anyway. |
kaspersv
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids materialising it in overlay mode.