Java: Allow taint-read-steps for array sources.#20589
Merged
aschackmull merged 3 commits intogithub:mainfrom Oct 7, 2025
Merged
Java: Allow taint-read-steps for array sources.#20589aschackmull merged 3 commits intogithub:mainfrom
aschackmull merged 3 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends taint tracking functionality in Java to include array elements as entrypoint types. This allows taint to flow through field reads of array element types when the array itself is a flow source from the active threat model.
- Adds array element types to the set of entrypoint types for taint tracking
- Enables field reads on array element types to be treated as taint steps
- Addresses a gap identified through a recent support case
owen-mc
reviewed
Oct 7, 2025
Contributor
owen-mc
left a comment
There was a problem hiding this comment.
I think it would be worth adding a test for this. And maybe a change note - even though it is quite technical, if end users start getting more results and want to figure out why, it would be good for them to be able to find an explanation.
owen-mc
approved these changes
Oct 7, 2025
Contributor
Author
|
Mainly one project gets more flow, which also shows in the timings, but otherwise dca is fairly quiet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain read steps are also allowed as taint steps, i.e. they treat a tainted object as if all of its fields are tainted as well. This applies to "entrypoint types", i.e. the types of the flow sources from the active threat model. This PR adds array elements to the set of entrypoint types, so that if a source has type
Foo[]then reading fields ofFoowill be considered default taint steps.A recent test case from a support issue highlighted that this was missing.