Java: Add integration test to reproduce regression#20657
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an integration test to reproduce a regression related to Maven wrapper projects that are missing properties files. The test sets up a minimal Java project with Maven wrapper scripts but intentionally omits the Maven wrapper properties file to trigger the regression scenario.
- Creates a new integration test case for Maven wrapper missing properties scenario
- Sets up a minimal Java "Hello World" project with Maven configuration
- Includes Maven wrapper scripts (mvnw and mvnw.cmd) without the properties file
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test.py | Defines the integration test function that creates a CodeQL database using autobuild mode |
| Hello.java | Simple Java class with main method for the test project |
| source_archive.expected | Expected files to be included in the source archive after database creation |
| pom.xml | Maven project configuration with basic compiler setup |
| mvnw.cmd | Windows Maven wrapper script that handles Maven execution and jar downloading |
| mvnw | Unix/Linux Maven wrapper script with similar functionality to the Windows version |
smowton
previously approved these changes
Oct 22, 2025
Contributor
smowton
left a comment
There was a problem hiding this comment.
Test looks sensible. Ideally we would verify mvnw is / isn't used as expected, but the other maven-wrapper tests are similarly just probing for a crash, so there's no immediate need to make that improvement now.
a9fa4ec to
97f26a4
Compare
97f26a4 to
0322197
Compare
smowton
approved these changes
Oct 27, 2025
0322197 to
1b212fd
Compare
1b212fd to
d473b36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See internal pR