Crypto: Fix bug in weak symmetric cipher query#20690
Merged
nicolaswill merged 1 commit intogithub:mainfrom Oct 24, 2025
Merged
Conversation
…er if !=AES but the algorithm must still be a SymmetriCipher algorithm.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the weak symmetric cipher detection query where the logic was incorrectly flagging non-symmetric cipher algorithms. The fix adds a type check to ensure only symmetric ciphers are evaluated.
- Added type constraint to limit detection to symmetric ciphers only
- Added test case with PBKDF2WithHmacSHA256 (a key derivation function, not a symmetric cipher) to verify the fix
- Updated test expectations with line number adjustments due to the new test case
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| WeakSymmetricCipher.qll | Added instanceof TSymmetricCipher constraint to ensure only symmetric cipher algorithms are checked |
| Test.java | Added test case using SecretKeyFactory with PBKDF2WithHmacSHA256 to verify non-symmetric algorithms are not flagged |
| WeakSymmetricCipher.expected | Updated expected test results with adjusted line numbers and added numbering prefix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nicolaswill
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weak symmetric cipher looks to see if the algorithm is not AES but is missing a type check to limit to just symmetric ciphers.