Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR generalizes existing models in the Rust CodeQL library by converting specific implementations to trait-based models, improving their applicability across different types. This follows previous work in PR #20652.
Key changes:
- Converted implementation-specific models to trait models using
<_ as Trait>notation - Added a new iterator model for async operations
- Updated test expectations to reflect newly detected taint flows
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
rust/ql/test/library-tests/dataflow/sources/net/test.rs |
Removed MISSING annotations indicating newly detected taint flows |
rust/ql/test/library-tests/dataflow/sources/net/InlineFlow.expected |
Updated test expectations with new model IDs and flow edges |
rust/ql/lib/codeql/rust/frameworks/stdlib/net.model.yml |
Generalized TcpStream read models to trait-based std::io::Read models |
rust/ql/lib/codeql/rust/frameworks/stdlib/core.model.yml |
Added trait model for async iterator next operation |
rust/ql/lib/codeql/rust/frameworks/rustls.model.yml |
Removed duplicate models now covered by generalized trait models |
rust/ql/lib/codeql/rust/frameworks/mysql.model.yml |
Generalized PooledConn models to trait-based Queryable models |
rust/ql/lib/codeql/rust/frameworks/mysql-async.model.yml |
Generalized Conn models to trait-based Queryable models |
rust/ql/lib/codeql/rust/frameworks/futures.model.yml |
Removed Box-specific iterator model and added generalized AsyncRead poll_read model |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hvitved
reviewed
Oct 28, 2025
Contributor
Author
|
I'm having a bit of difficulty with DCA runs failing, and I really do want to see the results for this PR. Please bare with me. |
hvitved
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalize more existing models to trait models. Follows on from #20652 and is covered by the same change note (assuming we merge soon enough).