Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request reorganizes model definitions across the Rust standard library and framework files to improve code organization. The key changes involve moving models to more appropriate locations based on their module origins and adding support for the tokio-postgres and async-std frameworks.
- Added new model files for tokio-postgres and async-std frameworks
- Moved core::alloc::layout::Layout models from core.model.yml to alloc.model.yml
- Moved iterator chain/take models from tokio/io.model.yml to core.model.yml
- Reorganized string and arithmetic operation models between core and alloc files
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rust/ql/lib/codeql/rust/frameworks/tokio/postgres.model.yml | New file adding SQL injection sinks and database sources for tokio-postgres client and row types |
| rust/ql/lib/codeql/rust/frameworks/tokio/io.model.yml | Removed misplaced iterator models that belong in core stdlib |
| rust/ql/lib/codeql/rust/frameworks/stdlib/core.model.yml | Added arithmetic operations and iterator models, removed Layout models moved to alloc, cleaned up string operation models |
| rust/ql/lib/codeql/rust/frameworks/stdlib/alloc.model.yml | Added Layout models from core, removed duplicate string operation models now in core |
| rust/ql/lib/codeql/rust/frameworks/asyncstd/net.model.yml | New file adding async-std network sources and I/O summaries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hvitved
reviewed
Nov 5, 2025
hvitved
previously approved these changes
Nov 5, 2025
hvitved
approved these changes
Nov 6, 2025
Contributor
Author
|
Thanks for re-approving! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up some models:
Shouldn't affect results (apart perhaps from lists of models used in tests).