Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes two independent changes: removing the compileForOverlayEval configuration option from the JavaScript QL pack and optimizing the directory deletion logic in the AutoBuild extractor.
- Removed
compileForOverlayEval: truefrom the JavaScript QL pack configuration - Changed from recursive to non-recursive directory deletion when cleaning up empty source folders
- Added specific exception handling for
DirectoryNotEmptyExceptionwhen the source folder is unexpectedly non-empty
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| javascript/ql/lib/qlpack.yml | Removes the compileForOverlayEval configuration option |
| javascript/extractor/src/com/semmle/js/extractor/AutoBuild.java | Optimizes directory deletion from recursive to non-recursive with appropriate exception handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mbg
approved these changes
Nov 4, 2025
Contributor
Author
|
Closing in favour of #20752 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Actions analysis uses the JS extractor to extract yaml files, and expects those files to be left in the WIP database in the event that no JS/TS code was found.