C++: Fix bad magic in IRGuards#20779
Merged
MathiasVP merged 1 commit intogithub:mainfrom Nov 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds pragma[nomagic] annotations to four override predicates in the GuardConditionFromBinaryLogicalOperator class to optimize query performance in the C++ control flow analysis library.
- Adds
pragma[nomagic]to thecomparesLtandcomparesEqpredicate overrides - Improves query performance by preventing magic sets expansion on these recursive predicates
- No functional code changes, only performance optimization annotations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aschackmull
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't have tuple counts for when this went wrong, but I do have this lovely table row from someone at Microsoft:
... Yes, that's 18 hours 😂 I guessed that the 2nd (3rd) parameter being bound by magic had something to do with it, and the end-to-end time went down to 2 hours after these changes 🎉