Conversation
The check for QLDoc comments was unfortunately broken for some time, so we missed this.
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing QLDoc documentation that was not caught due to a previously broken QLDoc comment checker. The change adds a documentation comment to a single method in the Java library.
- Adds QLDoc comment to the
getAUse()method in theSsaVariableclass
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
I don't think it was broken? The alerts it generates are ephemeral so we sometimes ignore some of them for various reasons. |
aschackmull
left a comment
There was a problem hiding this comment.
I mean sure, I'll approve, but I think this change was prompted by a misunderstanding of the ephemeral nature of the qldoc CI check.
when I said broken, I didn't mean they were not passing: they were silently not being run at all because of a misconfiguration of the triggers. On the other hand, yes, maybe this wasn't entirely necessary either 😅 |
The check for QLDoc comments was unfortunately broken for some time, so we missed this.