Conversation
geoffw0
added
no-change-note-required
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes documentation comments that were out of sync following changes in PR #20921. The comments incorrectly mentioned "boolean" types in barrier descriptions that only apply to numeric/integral types.
Key Changes:
- Removed references to "boolean" type from three barrier class comments
- Updated comments to accurately reflect that the barriers apply only to numeric/integral types
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| RegexInjectionExtensions.qll | Updated comment for IntegralTypeBarrier to remove "boolean" reference |
| SqlInjectionExtensions.qll | Updated comment for NumericTypeBarrier to remove "boolean" reference |
| LogInjectionExtensions.qll | Updated comment for NumericTypeBarrier to remove "boolean" reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
paldepind
approved these changes
Nov 27, 2025
Contributor
paldepind
left a comment
paldepind
left a comment
There was a problem hiding this comment.
Thanks! I missed those.
We could comment the other barrier uses, but to be honest I think the intent is very obvious.
Yes, I agree that it's pretty clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix for documentation being out of sync following #20921 .
We could comment the other barrier uses, but to be honest I think the intent is very obvious.
@paldepind