Docs: clarify behavior of range checks#21096
Merged
Conversation
The current wording (about the sets of values being "the same") is not accurate.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects inaccurate documentation about CodeQL range checks by clarifying that they check for "at least one value" in common rather than "the same set of values." The fix addresses issue #21068 where the previous wording incorrectly implied set equality semantics.
- Rewrites the description of range check behavior to accurately reflect CodeQL's "at least one common value" semantics
- Removes the misleading explanation that claimed
<expression> in <range>checks if sets are "the same" - Retains the note about equivalence between
inand=operators, which is consistent with CodeQL's equality semantics documented elsewhere
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21068
The current wording (about the sets of values being "the same") is not accurate.