Rust: Make function trait syntax without return type default to unit#21139
Merged
paldepind merged 2 commits intogithub:mainfrom Jan 12, 2026
Merged
Rust: Make function trait syntax without return type default to unit#21139paldepind merged 2 commits intogithub:mainfrom
paldepind merged 2 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements proper handling for Rust function trait syntax when the return type is omitted, making it default to the unit type () as per Rust language semantics. This aligns with Rust's specification where FnOnce(Args) is equivalent to FnOnce(Args) -> ().
Changes:
- Added logic to handle omitted return types in function trait syntax, defaulting to unit type
- Moved function trait handling from
getTypeMentionForTypeParametertogetTypeForTypeParameterAtto better reflect that a suitable type mention is present - Added test case to verify the behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/test/library-tests/type-inference/closure.rs | Added test case for FnOnce(bool) without return type to verify it defaults to () |
| rust/ql/test/library-tests/type-inference/type-inference.expected | Updated expected test results with new inferences and shifted line numbers |
| rust/ql/lib/codeql/rust/internal/TypeMention.qll | Moved and enhanced function trait handling logic to properly support omitted return types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hvitved
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the special
FnOnce(Args) -> ReturnTypesyntax, the return type can be omitted which is equivalent to specifying()as the return type.I moved the handling of this from
getTypeMentionForTypeParametertogetTypeForTypeParameterAtsince we now have a case where a suitable type mention is present.