JS: Add support for props callbacks in Vue router configs#21159
Merged
asgerf merged 3 commits intogithub:mainfrom Jan 19, 2026
Merged
JS: Add support for props callbacks in Vue router configs#21159asgerf merged 3 commits intogithub:mainfrom
asgerf merged 3 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for detecting taint sources in Vue Router's props configuration when it uses callback functions. The props option in Vue Router can be either a function that receives a route object, or an object where each property is a function receiving a route object. Previously, these callbacks were not modeled as sources of tainted data.
Changes:
- Extended the Vue Router model to detect route objects passed to props callbacks
- Added test cases covering both function-based and object-based props configurations
- Updated test expectations to reflect the new taint sources being detected
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| javascript/ql/lib/semmle/javascript/frameworks/Vue.qll | Added two new predicates to detect route objects in props callbacks (both function and object forms) |
| javascript/ql/test/library-tests/frameworks/Vue/router.js | Added test cases for props as a function and props as an object with function values |
| javascript/ql/test/library-tests/frameworks/Vue/tests.expected | Updated expected test results with new taint sources detected from props callbacks |
| javascript/ql/src/change-notes/2026-01-13-vue-props-callbacks.md | Added release notes documenting the enhancement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for the fix, @asgerf 🥇 |
|
Thank you @joshimar for catching this gap and raising the feedback! ✨ 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a missing endpoint to the
vue-routermodel