Rust: Add tests for Self constructors#21210
Merged
paldepind merged 2 commits intogithub:mainfrom Jan 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds test coverage for path resolution involving Self constructors in Rust. The tests verify that Self correctly resolves to the appropriate type (tuple structs, regular structs, and enum variants) in various contexts.
Changes:
- Added new test module
self_constructorswith tests forSelfconstructor resolution in tuple structs, regular structs, and enums - Updated expected test outputs to account for the new tests and line number shifts
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rust/ql/test/library-tests/type-inference/main.rs | Added a small test for Self constructor in a tuple struct implementing the Default trait |
| rust/ql/test/library-tests/type-inference/CONSISTENCY/PathResolutionConsistency.expected | Updated line numbers due to code additions (shifted by 11 lines) |
| rust/ql/test/library-tests/path-resolution/main.rs | Added comprehensive self_constructors module testing Self resolution in tuple structs, regular structs, and enum patterns |
| rust/ql/test/library-tests/path-resolution/path-resolution.expected | Added expected path resolution entries for the new test cases, including line number updates for existing tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hvitved
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some additional path resolution tests for paths that involve
Self. These all work but we don't have any tests covering these cases.