Avoid non-trivially shadowing string.toString()#21306
Merged
Conversation
Prepare libraries for a possible deprecation warning on shadowing string.toString(). These instanceof classes were using this.(Type).method() to call supertype methods, but super.method() is clearer and equivalent for instanceof supertypes.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the shared regex NFA QL libraries to avoid non-trivial shadowing patterns around string.toString() by replacing explicit supertype-cast calls (this.(Type).method()) with clearer super.method() forwarding in instanceof classes.
Changes:
- Replaced
this.(RegExpConstant).toString()/getRootTerm()/getValue()forwarding withsuper.*inRegexpCharacterConstant. - Replaced
this.(RegExpTerm).*forwarding withsuper.*inEffectivelyPlus,EffectivelyStar, andEffectivelyQuestion. - Replaced
this.(InfiniteRepetitionQuantifier).toString()forwarding withsuper.toString()inMaybeBacktrackingRepetition.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| shared/regex/codeql/regex/nfa/NfaUtils.qll | Switches forwarding calls in several instanceof classes from explicit cast-based dispatch to super.*. |
| shared/regex/codeql/regex/nfa/ExponentialBackTracking.qll | Updates toString() forwarding in an instanceof quantifier wrapper to use super.toString(). |
hvitved
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare libraries for a possible deprecation warning on shadowing
string.toString(), which currently can expose inconsistent behaviour (implicittoStringinsertion on string subclasses is problematic).These instanceof classes were using
this.(Type).method()to call supertype methods, butsuper.method()is clearer and equivalent for instanceof supertypes.