Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the npm package distribution was empty by removing the --ignore-scripts flag from the publish command, allowing prepublish scripts to run properly. It also updates the available GitHub models by adding new GPT-5 variants and removing deprecated Phi-3 models.
- Removes
--ignore-scriptsflag from npm publish command to ensure prepublish scripts execute - Adds new OpenAI GPT-5 model variants (gpt-5, gpt-5-chat, gpt-5-mini, gpt-5-nano)
- Removes deprecated Microsoft Phi-3 model variants
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/publish.yml | Removes --ignore-scripts flag to allow prepublish scripts to run during npm publish |
| src/model-id.ts | Updates model list by adding GPT-5 variants and removing Phi-3 models |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
maraisr
reviewed
Oct 7, 2025
Co-authored-by: Marais Rossouw <me@marais.co>
maraisr
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14
https://github.com/github/models-ai-sdk/issues
the npm package dist is empty. pretty sure it's because
--ignore-scriptsskips prePublish.also updated the models