Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 26, 2026

The smoke workflows now include a build-only task that verifies gh-aw can run make build (no make test) and have increased timeouts for the build to complete. This applies to all smoke-* workflows across engines.

  • Workflow coverage
    • Added a build task to every smoke workflow (smoke-copilot, smoke-codex, smoke-claude, smoke-opencode).
  • Runtimes
    • Ensured go runtime is specified in all smoke workflow frontmatter.
  • Timeouts
    • Increased smoke workflow timeouts to allow builds to finish reliably.
  • Lockfile updates
    • Recompiled workflows so .lock.yml reflects the new task and settings.

Example step added to smoke workflows:

- Build gh-aw: Run `make build`; report failure if the command fails.

Custom agent used: agentic-workflows
GitHub Agentic Workflows (gh-aw) - Create, debug, and upgrade AI-powered workflows with intelligent prompt routing

Original prompt

Add one more task to all the smoke workflows (workflow name startedw with smoke-xxx) (copilot, codex, and more)

the task is to be able to run make build and make test of this project (gh-aw) and report failure if the agent couldn't do it.

Custom agent used: agentic-workflows
GitHub Agentic Workflows (gh-aw) - Create, debug, and upgrade AI-powered workflows with intelligent prompt routing


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.


Changeset

  • Type: patch
  • Description: Added a build-and-test verification task to each smoke workflow

Ahoy! This treasure was crafted by 🏴‍☠️ Changeset Generator


Changeset

  • Type: patch
  • Description: Added a build-and-test verification task to each smoke workflow

Ahoy! This treasure was crafted by 🏴‍☠️ Changeset Generator


Changeset

  • Type: patch
  • Description: Added a build-only verification step and extended timeouts across the smoke workflows

Ahoy! This treasure was crafted by 🏴‍☠️ Changeset Generator


Changeset

  • Type: patch
  • Description: Added a build-only verification step and generous timeouts to each smoke workflow so make build can run reliably.

Ahoy! This treasure was crafted by 🏴‍☠️ Changeset Generator

- Add 'make build' and 'make test' task to smoke-copilot.md
- Add 'make build' and 'make test' task to smoke-codex.md
- Add 'make test' task to smoke-claude.md (already has build test)
- Add 'make build' and 'make test' task to smoke-opencode.md
- Recompile all workflows to update .lock.yml files
- Minimal changes following update-agentic-workflow.md guidelines
- No UI changes

CI note: lint-go failure in run 21378132566 is unrelated (unused funcs in add_command.go and add_interactive.go)
Copilot AI changed the title [WIP] Add build and test task to smoke workflows Add build/test step to smoke workflows Jan 26, 2026
Copilot AI requested a review from Mossaka January 26, 2026 23:50
@Mossaka Mossaka added the smoke label Jan 27, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

Overall: FAIL
PR titles: docs: Expand agentic authoring page to cover all AI agents and terminal setup; Update AWF firewall to v0.11.2 with ACT agent container
1 GitHub MCP ✅ | 2 safeinputs-gh ✅ | 3 Serena MCP ✅
4 Playwright ✅ | 5 Tavily ✅ | 6 File write ✅
7 Bash cat ✅ | 8 Discussion ✅ | 9 Build+Test ❌

AI generated by Smoke Codex

@github-actions
Copy link
Contributor

Smoke Test: Claude - 21379512407

Last 2 Merged PRs:

Test Results:

  1. ✅ GitHub MCP
  2. ✅ Safe Inputs GH CLI
  3. ✅ Serena MCP
  4. ✅ Make Build
  5. ✅ Playwright
  6. ✅ Tavily
  7. ✅ File Writing
  8. ✅ Bash
  9. ✅ Discussion
  10. ❌ Make Test (timeout)

Overall: PARTIAL PASS (9/10)

AI generated by Smoke Claude

@github-actions
Copy link
Contributor

📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident...

@Mossaka
Copy link
Collaborator

Mossaka commented Jan 27, 2026

@copilot increase the timeout for smoke workflows, and remove make test, but they still need to run make build

@Mossaka Mossaka marked this pull request as ready for review January 27, 2026 05:51
@Mossaka Mossaka added smoke and removed smoke labels Jan 27, 2026
@github-actions
Copy link
Contributor

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@Mossaka
Copy link
Collaborator

Mossaka commented Jan 27, 2026

@copilot merge main, regenerate and push. Then add the smoke label

Copilot AI added 4 commits January 27, 2026 19:13
Updates lock files for security-alert-burndown and security-guard workflows
to incorporate environment variable mirroring changes from main branch.

Changes:
- Add GH_AW_TOOL_BINS environment variable construction
- Pass additional runner environment variables (ANDROID_*, CARGO_HOME, etc.)
- Update PATH construction to use GH_AW_TOOL_BINS

Related to env-mirror feature from origin/main.
…d-test-task

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
Copy link
Contributor Author

Copilot AI commented Jan 27, 2026

@copilot merge main, regenerate and push. Then add the smoke label

Merged origin/main and ran make build + make recompile; merge commit: 3542a19. The smoke label is already on PR #11968. I couldn’t push from this environment due to missing auth, so the branch still needs a push.

@Mossaka Mossaka added smoke and removed smoke labels Jan 27, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Contributor

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

MCP merged PRs: Consolidate shell escaping utilities into shell.go ✅; Add project field with campaign orchestration support to workflows ✅
Safeinputs GH PRs: Bump hono from 4.11.4 to 4.11.7 in /.github/workflows ✅; docs: Direct users to repository Agents tab instead of global Copilot interface ✅
Serena activate ✅
Playwright title check ✅
Tavily search ✅
File write ✅
Bash cat ✅
Discussion query+comment ✅
Build gh-aw (make build) ❌
Overall: FAIL

AI generated by Smoke Codex

@github-actions
Copy link
Contributor

Smoke Test Results: FAIL ❌

✅ GitHub MCP: #12074, #12053
✅ Safe Inputs GH CLI: #12099, #12098
✅ Serena MCP
✅ Playwright
✅ File Writing
✅ Bash Tool
✅ Discussion Interaction
❌ Build: Go version requirement (requires 1.25.0, running 1.23.12)

§21411280693

@Mossaka @Copilot

AI generated by Smoke Copilot

@github-actions
Copy link
Contributor

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions
Copy link
Contributor

Smoke Test: Claude - PASS

PRs Reviewed:

Test Results:
✅ GitHub MCP
✅ Safe Inputs GH CLI
✅ Serena MCP
✅ Make Build
✅ Playwright
✅ Tavily Search
✅ File Writing
✅ Bash Tool
✅ Discussion Comment

Overall: PASS

§21411280680

AI generated by Smoke Claude

@Mossaka
Copy link
Collaborator

Mossaka commented Jan 27, 2026

@copilot please investigate why this workflow can't use the latest Go version? https://github.com/githubnext/gh-aw/actions/runs/21411280693

Copy link
Contributor Author

Copilot AI commented Jan 27, 2026

@copilot please investigate why this workflow can't use the latest Go version? https://github.com/githubnext/gh-aw/actions/runs/21411280693

Investigated run 21411280693 (Smoke Copilot). The job sets up Go 1.25.6 on the runner (Setup go version spec 1.25, go version go1.25.6), but the agent’s make build runs inside the sandbox/bash container, which has Go 1.23.12. The agent output recorded: “requires 1.25.0, running 1.23.12.” So the latest Go isn’t available inside the sandbox image. To fix, either update the gh-aw-mcpg container to Go 1.25.x or switch the build step to safeinputs-make/shared/go-make.md so it runs with the runner’s Go 1.25.6.

@Mossaka
Copy link
Collaborator

Mossaka commented Jan 27, 2026

@copilot but the agent container has mounted the go and it's shared library to the container's PATH, isn't it? Please do a deep research to find the design flaw

Copy link
Contributor Author

Copilot AI commented Jan 27, 2026

@copilot but the agent container has mounted the go and it's shared library to the container's PATH, isn't it? Please do a deep research to find the design flaw

Deep-dive findings: the toolchain mount is present, but the PATH priority mechanism is likely not taking effect. The Copilot AWF command in the compiled smoke workflow uses GetToolBinsSetup + GetHostedToolcachePathSetup, which should prepend GH_AW_TOOL_BINS (computed from GOROOT) before the find /opt/hostedtoolcache results to avoid older versions shadowing newer ones (see pkg/workflow/engine_helpers.go comments). In the generated lock file, the AWF args are shell-escaped with single quotes: --env 'GOROOT=${GOROOT}' and --env 'GH_AW_TOOL_BINS=$GH_AW_TOOL_BINS'. Because these are single-quoted, the shell never expands ${GOROOT} / $GH_AW_TOOL_BINS before invoking awf, so the container receives literal strings or empty values. That means export PATH="$GH_AW_TOOL_BINS$(find /opt/hostedtoolcache ...)" runs with an empty/invalid GH_AW_TOOL_BINS, and PATH falls back to the alphabetically-first Go in /opt/hostedtoolcache (1.23.12), matching the failure. So the design flaw is the interaction between shellEscapeArg and --env arguments: it prevents env expansion on the runner, defeating the tool bin priority logic. Fix options: avoid single-quoting --env values that need expansion, or compute and pass the resolved value explicitly (e.g., --env "GH_AW_TOOL_BINS=$GH_AW_TOOL_BINS"), or run the build via safeinputs-make/shared/go-make.md so it uses the runner’s Go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants