Skip to content

[code-simplifier] Remove redundant ANSI stripping comments #12271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Jan 28, 2026
Merged

[code-simplifier] Remove redundant ANSI stripping comments #12271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions pkg/workflow/compiler_yaml.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ func (c *Compiler) generateWorkflowHeader(yaml *strings.Builder, data *WorkflowD

// Add description comment if provided
if data.Description != "" {
// Strip ANSI escape codes to prevent terminal color codes in YAML
cleanDescription := stringutil.StripANSIEscapeCodes(data.Description)
// Split description into lines and prefix each with "# "
descriptionLines := strings.Split(strings.TrimSpace(cleanDescription), "\n")
Expand All @@ -68,7 +67,6 @@ func (c *Compiler) generateWorkflowHeader(yaml *strings.Builder, data *WorkflowD
// Add source comment if provided
if data.Source != "" {
yaml.WriteString("#\n")
// Strip ANSI escape codes from source path
cleanSource := stringutil.StripANSIEscapeCodes(data.Source)
fmt.Fprintf(yaml, "# Source: %s\n", cleanSource)
}
Expand All @@ -81,7 +79,6 @@ func (c *Compiler) generateWorkflowHeader(yaml *strings.Builder, data *WorkflowD
if len(data.ImportedFiles) > 0 {
yaml.WriteString("# Imports:\n")
for _, file := range data.ImportedFiles {
// Strip ANSI escape codes from file paths
cleanFile := stringutil.StripANSIEscapeCodes(file)
fmt.Fprintf(yaml, "# - %s\n", cleanFile)
}
Expand All @@ -90,7 +87,6 @@ func (c *Compiler) generateWorkflowHeader(yaml *strings.Builder, data *WorkflowD
if len(data.IncludedFiles) > 0 {
yaml.WriteString("# Includes:\n")
for _, file := range data.IncludedFiles {
// Strip ANSI escape codes from file paths
cleanFile := stringutil.StripANSIEscapeCodes(file)
fmt.Fprintf(yaml, "# - %s\n", cleanFile)
}
Expand All @@ -100,15 +96,13 @@ func (c *Compiler) generateWorkflowHeader(yaml *strings.Builder, data *WorkflowD
// Add stop-time comment if configured
if data.StopTime != "" {
yaml.WriteString("#\n")
// Strip ANSI escape codes from stop time
cleanStopTime := stringutil.StripANSIEscapeCodes(data.StopTime)
fmt.Fprintf(yaml, "# Effective stop-time: %s\n", cleanStopTime)
}

// Add manual-approval comment if configured
if data.ManualApproval != "" {
yaml.WriteString("#\n")
// Strip ANSI escape codes from manual approval environment
cleanManualApproval := stringutil.StripANSIEscapeCodes(data.ManualApproval)
fmt.Fprintf(yaml, "# Manual approval required: environment '%s'\n", cleanManualApproval)
}
Expand Down