-
Notifications
You must be signed in to change notification settings - Fork 0
chore: standardize Docker base images to approved platform images #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Replace mcr.microsoft.com/devcontainers/base:ubuntu-24.04 with approved ubuntu:22.04 base image to align with platform standards. Co-authored-by: Ona <no-reply@ona.com>
| @@ -1,4 +1,5 @@ | |||
| FROM mcr.microsoft.com/devcontainers/base:ubuntu-24.04 | |||
| # Standardized to approved base image (ubuntu:22.04 instead of ubuntu-24.04 devcontainer base) | |||
| FROM ubuntu:22.04 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ Info: Updated from mcr.microsoft.com/devcontainers/base:ubuntu-24.04 to ubuntu:22.04.
Key differences:
- The Microsoft devcontainer base includes pre-installed tools (git, sudo, common utilities) and a non-root user setup
- The official
ubuntu:22.04is a minimal base that requires explicit installation of these tools - Ubuntu 24.04 → 22.04 is a downgrade to the LTS version for stability
Why this works:
- Both are Debian-based (apt package manager compatibility)
- The Dockerfile already installs all required tools explicitly
- No reliance on devcontainer-specific features
📋 Reviewer GuidanceThis PR standardizes the devcontainer base image. Here's what to verify: ✅ What's Safe
|
| @@ -1,4 +1,5 @@ | |||
| FROM mcr.microsoft.com/devcontainers/base:ubuntu-24.04 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-installed in devcontainer base (now missing):
git,sudo,wget,vim,less,jq,openssh-client- Non-root
vscodeuser with passwordless sudo - Common shell utilities and development tools
Action required: If your workflow depends on any of these tools, add them explicitly to the Dockerfile. For example:
RUN apt-get update && apt-get install -y git sudo vim && rm -rf /var/lib/apt/lists/*
🔍 Line-by-Line AnalysisLine 2:
|
🔒 Security & Stability BenefitsVersion Pinning✅ Before: Why this matters:
Ubuntu 24.04 → 22.04 DowngradeThis is intentional and beneficial:
ReproducibilityThe Microsoft devcontainer base image can change over time as Microsoft updates it. The official |
This pull request updates the Docker base images in this repository to align with our org's approved base image standards. These changes were generated automatically by Ona as part of our platform-wide standardization effort.
Changes Made
.devcontainer/Dockerfilemcr.microsoft.com/devcontainers/base:ubuntu-24.04ubuntu:22.04Benefits
Testing
The devcontainer should continue to function as expected with the Ubuntu 22.04 LTS base image, as both the previous and new base images are Ubuntu-based and the Docker installation commands remain compatible.