Skip to content

fix(#98): initial device computation breaking sensor usages #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gladiuscode merged 6 commits into from
Dec 17, 2025
Merged

fix(#98): initial device computation breaking sensor usages #100

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2884cc9
fix: initial device computation breaking sensor usages
gladiuscode Dec 17, 2025
c8862ab
fix: pr issue
gladiuscode Dec 17, 2025
e1b1ced
fix: pr issue
gladiuscode Dec 17, 2025
1074c03
refactor: useless code change
gladiuscode Dec 17, 2025
71d55b0
refactor: code structure
gladiuscode Dec 17, 2025
1542be2
fix: code readability and small issue
gladiuscode Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions ...oid/src/main/java/com/orientationdirector/implementation/OrientationDirectorModuleImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ class OrientationDirectorModuleImpl internal constructor(private val context: Re
checkInterfaceOrientation(false)
}

// NOTE(1.init): This is needed to compute the initial device orientation
mOrientationSensorsEventListener.enable()

context.addLifecycleEventListener(mLifecycleListener)
mLifecycleListener.setOnHostResumeCallback {
if (!didComputeInitialDeviceOrientation || areOrientationSensorsEnabled) {
Expand All @@ -45,17 +48,17 @@ class OrientationDirectorModuleImpl internal constructor(private val context: Re
mBroadcastReceiver.register()
}
mLifecycleListener.setOnHostPauseCallback {
if (initialized && areOrientationSensorsEnabled) {
if (!didComputeInitialDeviceOrientation || areOrientationSensorsEnabled) {
mOrientationSensorsEventListener.disable()
mAutoRotationObserver.disable()
}
mAutoRotationObserver.disable()
mBroadcastReceiver.unregister()
}
mLifecycleListener.setOnHostDestroyCallback {
if (areOrientationSensorsEnabled) {
if (!didComputeInitialDeviceOrientation || areOrientationSensorsEnabled) {
mOrientationSensorsEventListener.disable()
mAutoRotationObserver.disable()
}
mAutoRotationObserver.disable()
mBroadcastReceiver.unregister()
}

Expand Down Expand Up @@ -163,8 +166,14 @@ class OrientationDirectorModuleImpl internal constructor(private val context: Re

checkInterfaceOrientation()

if (!didComputeInitialDeviceOrientation) {
didComputeInitialDeviceOrientation = true
// NOTE(2.init): This is needed to disable sensors if they were needed just for the initial
// device computation.
if (didComputeInitialDeviceOrientation) {
return
}
didComputeInitialDeviceOrientation = true

if (!areOrientationSensorsEnabled) {
mOrientationSensorsEventListener.disable()
}
}
Expand Down