Skip to content

fix: expo plugin breaking due to override keyword not supported in version 54 #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gladiuscode merged 1 commit into from
Oct 20, 2025
Merged

fix: expo plugin breaking due to override keyword not supported in version 54 #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion plugin/src/withRNOrientationAppDelegate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export function swiftFileUpdater(
originalContents: string,
sdkVersion?: string
): string {
const methodPrefix = !sdkVersion?.includes('53') ? 'override' : '';
const methodPrefix = computeMethodPrefix(sdkVersion);
const supportedInterfaceOrientationsForCodeBlock = `\n ${methodPrefix} func application(_ application: UIApplication, supportedInterfaceOrientationsFor window: UIWindow?) -> UIInterfaceOrientationMask {
return OrientationDirector.getSupportedInterfaceOrientationsForWindow()
}\n`;
Expand All @@ -77,6 +77,24 @@ export function swiftFileUpdater(
});

return results.contents;

function computeMethodPrefix(_sdkVersion?: string) {
if (!_sdkVersion) {
return '';
}

const sdkVersionAsNumber = Number(_sdkVersion);
if (Number.isNaN(sdkVersionAsNumber)) {
return '';
}

if (sdkVersionAsNumber >= 53) {
return '';
}

// Older SDK versions need the override keyword
return 'override';
}
}

export function objCFileUpdater(originalContents: string): string {
Expand Down
Loading