chore: update eslint to v10 and fix linting errors

.github/workflows/test.yml

@@ -28,4 +28,4 @@ jobs:
         run: |
           yarn build-types
           [ $(git diff types.d.ts | wc -l) -gt 0 ] && echo 'Diff exists in types.d.ts. Please change jsdoc.' && exit 1
-          tsc --noEmit types.d.ts
+          tsc --noEmit types.d.ts --skipLibCheck

package.json

@@ -59,12 +59,12 @@
   "devDependencies": {
     "@babel/core": "^7.27.4",
     "@babel/preset-env": "^7.27.2",
-    "@eslint/js": "^9.29.0",
+    "@eslint/js": "^10.0.1",
     "@types/node": "^25.2.3",
     "babel-loader": "^10.0.0",
     "benchmark": "^2.1.4",
     "coveralls": "^3.0.3",
-    "eslint": "^9.29.0",
+    "eslint": "^10.0.0",
     "eslint-config-prettier": "^10.1.5",
     "eslint-plugin-jest": "^29.0.1",
     "eslint-plugin-prettier": "^5.5.0",

src/ast.js

@@ -364,7 +364,6 @@ AST.prototype.prepare = function (kind, docs, parser) {
   const self = this;
   // returns the node
   const result = function () {
-    let location = null;
     const args = Array.prototype.slice.call(arguments);
     args.push(docs);
     if (self.withPositions || self.withSource) {
@@ -373,7 +372,7 @@ AST.prototype.prepare = function (kind, docs, parser) {
         src = parser.lexer._input.substring(start.offset, parser.prev[2]);
       }
       // if with source, need location on swapLocations function
-      location = new Location(
+      const location = new Location(
         src,
         start,
         new Position(parser.prev[0], parser.prev[1], parser.prev[2]),

src/lexer/attribute.js

@@ -9,10 +9,10 @@ module.exports = {
   attributeIndex: 0,
   attributeListDepth: {},
   matchST_ATTRIBUTE() {
-    let ch = this.input();
+    const ch = this.input();
     if (this.is_WHITESPACE()) {
       do {
-        ch = this.input();
+        this.input();
       } while (this.is_WHITESPACE());
       this.unput(1);
       return null;

src/parser/array.js

@@ -14,7 +14,7 @@ module.exports = {
    * ```
    */
   read_array() {
-    let expect = null;
+    let expect;
     let shortForm = false;
     const result = this.node("array");
 
@@ -74,7 +74,7 @@ module.exports = {
     const entry = this.node("entry");
 
     let key = null;
-    let value = null;
+    let value;
     let byRef = false;
     let unpack = false;
 

src/parser/class.js

@@ -431,8 +431,8 @@ module.exports = {
    * ```
    */
   read_interface_body() {
-    let result = [],
-      attrs = [];
+    let result = [];
+    let attrs;
 
     while (this.token !== this.EOF && this.token !== "}") {
       if (this.token === this.tok.T_COMMENT) {
@@ -458,7 +458,6 @@ module.exports = {
           this.next();
         }
         result = result.concat(constants);
-        attrs = [];
       } else if (this.token === this.tok.T_FUNCTION) {
         // reads a function
         const method = this.read_function_declaration(
@@ -472,7 +471,6 @@ module.exports = {
         if (this.expect(";")) {
           this.next();
         }
-        attrs = [];
       } else {
         // raise an error
         this.error([this.tok.T_CONST, this.tok.T_FUNCTION]);

src/parser/expr.js

@@ -678,13 +678,11 @@ module.exports = {
     if (this.version < 800) {
       this.raiseError("Match statements are not allowed before PHP 8");
     }
-    let cond = null;
-    let arms = [];
     if (this.expect("(")) this.next();
-    cond = this.read_expr();
+    const cond = this.read_expr();
     if (this.expect(")")) this.next();
     if (this.expect("{")) this.next();
-    arms = this.read_match_arms();
+    const arms = this.read_match_arms();
     if (this.expect("}")) this.next();
     return node(cond, arms);
   },

src/parser/function.js

@@ -252,7 +252,6 @@ module.exports = {
     const node = this.node("parameter");
     let parameterName = null;
     let value = null;
-    let types = null;
     let nullable = false;
     let readonly = false;
     let attrs = [];
@@ -290,7 +289,7 @@ module.exports = {
       this.next();
       nullable = true;
     }
-    types = this.read_types();
+    const types = this.read_types();
     if (nullable && !types) {
       this.raiseError(
         "Expecting a type definition combined with nullable operator",

src/parser/if.js

@@ -16,7 +16,7 @@ module.exports = {
   read_if() {
     const result = this.node("if");
     const test = this.next().read_if_expr();
-    let body = null;
+    let body;
     let alternate = null;
     let shortForm = false;
 

src/parser/loops.js

@@ -17,11 +17,10 @@ module.exports = {
   read_while() {
     const result = this.node("while");
     this.expect(this.tok.T_WHILE) && this.next();
-    let test = null;
-    let body = null;
+    let body;
     let shortForm = false;
     if (this.expect("(")) this.next();
-    test = this.read_expr();
+    const test = this.read_expr();
     if (this.expect(")")) this.next();
     if (this.token === ":") {
       shortForm = true;
@@ -43,8 +42,7 @@ module.exports = {
     const result = this.node("do");
     this.expect(this.tok.T_DO) && this.next();
     let test = null;
-    let body = null;
-    body = this.read_statement();
+    const body = this.read_statement();
     if (this.expect(this.tok.T_WHILE)) {
       if (this.next().expect("(")) this.next();
       test = this.read_expr();
@@ -69,7 +67,7 @@ module.exports = {
     let init = [];
     let test = [];
     let increment = [];
-    let body = null;
+    let body;
     let shortForm = false;
     if (this.expect("(")) this.next();
     if (this.token !== ";") {
@@ -109,13 +107,12 @@ module.exports = {
   read_foreach() {
     const result = this.node("foreach");
     this.expect(this.tok.T_FOREACH) && this.next();
-    let source = null;
     let key = null;
     let value = null;
-    let body = null;
+    let body;
     let shortForm = false;
     if (this.expect("(")) this.next();
-    source = this.read_expr();
+    const source = this.read_expr();
     if (this.expect(this.tok.T_AS)) {
       this.next();
       value = this.read_foreach_variable();

src/parser/scalar.js

@@ -357,7 +357,6 @@ module.exports = {
       curly = true;
       // dynamic variable name
       // https://github.com/php/php-src/blob/master/Zend/zend_language_parser.y#L1239
-      name = null;
       if (this.next().token === this.tok.T_STRING_VARNAME) {
         name = this.node("variable");
         const varName = this.text();
@@ -433,7 +432,7 @@ module.exports = {
     this.next();
     const start = this.lexer.yylloc.prev_offset - (isBinary ? 1 : 0);
     const value = [];
-    let type = null;
+    let type;
 
     if (expect === "`") {
       type = this.ast.encapsed.TYPE_SHELL;

src/parser/variable.js

@@ -118,8 +118,8 @@ module.exports = {
   },
 
   read_what(is_static_lookup = false) {
-    let what = null;
-    let name = null;
+    let what;
+    let name;
     switch (this.next().token) {
       case this.tok.T_STRING:
         what = this.node("identifier");