chore: Bring back multipart form field workaround #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arrays" The changes on the Speakeasy side don't seem to be working as intended. Specifically, `multipartArrayFormat: standard` does not cause `src/glean/api_client/utils/forms.py` to be updated upon the next re-generation. This brings back the manual work around for now, while we debug what is going on with the generation issue. The way the original fix works is that if we end up with fields that end with `[]` they are corrected, which means our work around is safe to have alongside the fixed generation (because once the generation is fixed there won't be any fields with `[]`). This reverts commit cbf4a87.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes on the Speakeasy side don't seem to be working as intended. Specifically,
multipartArrayFormat: standarddoes not causesrc/glean/api_client/utils/forms.pyto be updated upon the next re-generation.This brings back the manual work around for now, while we debug what is going on with the generation issue. The way the original fix works is that if we end up with fields that end with
[]they are corrected, which means our work around is safe to have alongside the fixed generation (because once the generation is fixed there won't be any fields with[]).This reverts commit cbf4a87.