Open
Conversation
froozeify
requested review from
Rom1-B and
stonebuzz
and removed request for
AdrienClairembault and
trasher
Rom1-B
suggested changes
Jan 5, 2026
| run: | | ||
| sudo service apache2 start | ||
| - name: "Setup coverage driver" | ||
| if: ${{ !cancelled() && inputs.code-coverage == true }} |
Contributor
There was a problem hiding this comment.
For activation, I think we need to follow the same logic as the other steps and test for the presence of the configuration file instead of defining a variable.
Suggested change
| if: ${{ !cancelled() && inputs.code-coverage == true }} | |
| if: ${{ !cancelled() && hashFiles(format('{0}/cobertura.xml', inputs.plugin-key)) != '' }} |
Same logic every time you test inputs.code-coverage == true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add code coverage support for plugin.
By default the coverage is not enabled.
For a better output, plugin can extract the report to automatically create a comment on the PR with the report in md format.
Interconnected PR :
Whatsapp plugin got a dedicated PR to test the modification (see in the feed under for the link)