Add RFC3164 parsing and TCP collector code #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: netsyslog.py
Owner
|
Cheers for this. Sorry it's taken me a few weeks to get to it – work is mental at the moment. Comments on commits to follow… |
Owner
|
Okay, I think that's all my comments on the commits done. If you agree with/fancy making any of the suggested changes, could we have a topic branch (e.g. We should also rebase those two merge commits out of the way (I can help with the git for that if necessary) to keep the commit log clean. Damn I love Python. It's been a while since I've spent more than two minutes looking at some, and it's been fun. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables messages to be received from the wire and parsed into Syslog objects.