refactor(broker): AsyncProducer function to apply options directly within the returned function#147
Open
charlieLin101274 wants to merge 1 commit intogo-micro:mainfrom
Open
Conversation
…thin the returned function - Modified AsyncProducer to set `errors` and `successes` channels directly within the returned function instead of returning a separate option function. - Ensures that both channels are properly applied to the `broker.Options` when provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where the AsyncProducer function could not be used as demonstrated in the README.md example. The original implementation of AsyncProducer returned a single option function that could only apply one of the errors or successes channels, leading to incorrect behavior when both channels were provided.
Changes
This fix allows users to properly capture both producer errors and successes when using the AsyncProducer function, improving the reliability and correctness of the Kafka broker setup.