streaming: reintroduce websocket ping/pong conn configurer #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-add the pingPonger ConnConfigureFunc for the Subscribe endpoint that was removed at some point. This configurer periodically pings clients and cancels the request context if they fail to respond with a pong, improving connection health detection for server-side streaming endpoints. Also fix errorHandler to log write errors instead of discarding them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-add the
pingPongerConnConfigureFuncfor the Subscribe endpoint that was removed at some point.This configurer:
Also fixes
errorHandlerto log write errors instead of discarding them with_, _ = ....Reference:
examples/streaming/cmd/chatter/http.go
Lines 58 to 59 in 9bf2e92