Skip to content

Fix tests #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Oct 11, 2022
Merged

Fix tests #1163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46f8740
Fix EqualsVerifier tests
liry Oct 11, 2022
46e133e
Bump mvn plugin versions
liry Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...c/test/groovy/com/gooddata/sdk/model/executeafm/afm/filter/ComparisonConditionTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
package com.gooddata.sdk.model.executeafm.afm.filter

import nl.jqno.equalsverifier.EqualsVerifier
import nl.jqno.equalsverifier.Warning
import org.apache.commons.lang3.SerializationUtils
import spock.lang.Specification
import spock.lang.Unroll
Expand Down Expand Up @@ -124,6 +125,6 @@ class ComparisonConditionTest extends Specification {

def "should verify equals"() {
expect:
EqualsVerifier.forClass(ComparisonCondition).usingGetClass().verify()
EqualsVerifier.forClass(ComparisonCondition).usingGetClass().suppress(Warning.BIGDECIMAL_EQUALITY).verify()
}
}
3 changes: 2 additions & 1 deletion ...el/src/test/groovy/com/gooddata/sdk/model/executeafm/afm/filter/RangeConditionTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
package com.gooddata.sdk.model.executeafm.afm.filter

import nl.jqno.equalsverifier.EqualsVerifier
import nl.jqno.equalsverifier.Warning
import org.apache.commons.lang3.SerializationUtils
import spock.lang.Specification
import spock.lang.Unroll
Expand Down Expand Up @@ -112,6 +113,6 @@ class RangeConditionTest extends Specification {

def "should verify equals"() {
expect:
EqualsVerifier.forClass(RangeCondition).usingGetClass().verify()
EqualsVerifier.forClass(RangeCondition).usingGetClass().suppress(Warning.BIGDECIMAL_EQUALITY).verify()
}
}
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@
<spring.version>5.3.22</spring.version>
<jadler.version>1.3.1</jadler.version>
<json-unit.version>2.36.0</json-unit.version>
<surefire.version>2.22.2</surefire.version>
<failsafe.version>2.22.2</failsafe.version>
<surefire.version>3.0.0-M7</surefire.version>
<failsafe.version>3.0.0-M7</failsafe.version>
</properties>

<build>
Expand Down