fix: changed some nav landmarks to div and div to nav for better accessibility

risk: low
JIRA: DP-3086

Author: ParzivalPavlis

docs/layouts/partials/header-menu.html

@@ -0,0 +1,24 @@
+<nav class="gd-docs-header-nav__center gd-header" aria-label="Main">
+    <input type="checkbox" role="button" id="gd-header-mobile-menu-trigger-input" name="gd-header-mobile-menu-trigger-input" class="gd-header-mobile gd-header-mobile-menu-trigger-input" aria-label="Open navigation menu" aria-controls="gd-header-mobile-menu" aria-expanded="false">
+    <label tabindex="0" for="gd-header-mobile-menu-trigger-input" class="gd-header-mobile gd-header-mobile-menu-trigger"><span></span></label>
+    <ul class="gd-docs-header-nav__menu gd-header-links">
+        <li class="gd-docs-header-nav__menuitem gd-header-link-item gd-header-link-item-mobile-only">
+            <a href="https://www.gooddata.com/learn/" class="gd-docs-header-nav__menulink gd-header-link gd-header-link__main">Learn</a>
+        </li>
+        <li class="gd-docs-header-nav__menuitem gd-header-link-item">
+            <a href="https://university.gooddata.com/" class="gd-docs-header-nav__menulink gd-header-link">University</a>
+        </li>
+        <li class="gd-docs-header-nav__menuitem gd-header-link-item">
+            <a href="https://community.gooddata.com/" class="gd-docs-header-nav__menulink gd-header-link">Community</a>
+        </li>
+        <li class="gd-docs-header-nav__menuitem gd-header-link-item">
+            <a href="https://www.gooddata.com/docs/cloud/" class="gd-docs-header-nav__menulink gd-header-link gd-header-link__active">Documentation</a>
+        </li>
+        <li class="gd-docs-header-nav__menuitem gd-header-link-item">
+            <a href="https://support.gooddata.com/hc/en-us" class="gd-docs-header-nav__menulink gd-header-link">Support</a>
+        </li>
+        <li class="gd-docs-header-nav__menuitem gd-header-link-item gd-header-link-item-mobile-only">
+            <a href="https://www.gooddata.com/" class="button">Go to GoodData.com</a>
+        </li>
+    </ul>
+</nav>

docs/layouts/partials/navbar-breadcrumb.html

@@ -0,0 +1,10 @@
+<nav class="gd-docs-header-nav__left" aria-label="Breadcrumbs">
+    <ul class="gd-breadcrumb">
+      <li class="gd-breadcrumb-item">
+        <a href="https://www.gooddata.com/docs/">All Products</a>
+      </li>
+      <li class="gd-breadcrumb-item">
+        <span> &nbsp;Python SDK</span>
+      </li>
+    </ul>
+</nav>

docs/layouts/partials/navbar.html

@@ -1,48 +1,18 @@
+{{/* (C) 2023 GoodData Corporation */}}
+
 {{ $cover := .HasShortcode "blocks/cover" }}
-<nav class="gd-docs-header-nav gd-docs-header-nav__first">
-  <div class="gd-docs-header-nav__left">
+<div class="gd-docs-header-nav gd-docs-header-nav__first">
+  <nav class="gd-docs-header-nav__left" aria-label="Homepage">
     <a class="gd-docs-header-nav__logo gd-header-nav__logo" href="{{ (printf "%s%s/" .Site.Home.Permalink "latest" ) | safeURL }}" >
       {{ with resources.Get "icons/GoodDataLearn.svg" }}{{ ( . | minify).Content | safeHTML }}{{ end }}
     </a>
     <span class="gd-header-nav__logo-text">Learn</span>
-  </div>
-  <div class="gd-docs-header-nav__center gd-header">
-    <input type="checkbox" id="gd-header-mobile-menu-trigger-input" name="gd-header-mobile-menu-trigger-input" class="gd-header-mobile gd-header-mobile-menu-trigger-input">
-    <label for="gd-header-mobile-menu-trigger-input" class="gd-header-mobile gd-header-mobile-menu-trigger"><span></span></label>
-    <ul class="gd-docs-header-nav__menu gd-header-links">
-      <li class="gd-docs-header-nav__menuitem gd-header-link-item gd-header-link-item-mobile-only">
-        <a href="https://www.gooddata.com/learn/" class="gd-docs-header-nav__menulink gd-header-link gd-header-link__main">Learn</a>
-      </li>
-      <li class="gd-docs-header-nav__menuitem gd-header-link-item">
-        <a href="https://university.gooddata.com/" class="gd-docs-header-nav__menulink gd-header-link">University</a>
-      </li>
-      <li class="gd-docs-header-nav__menuitem gd-header-link-item">
-        <a href="https://community.gooddata.com/" class="gd-docs-header-nav__menulink gd-header-link">Community</a>
-      </li>
-      <li class="gd-docs-header-nav__menuitem gd-header-link-item">
-        <a href="https://www.gooddata.com/docs/cloud/" class="gd-docs-header-nav__menulink gd-header-link gd-header-link__active">Documentation</a>
-      </li>
-      <li class="gd-docs-header-nav__menuitem gd-header-link-item">
-        <a href="https://support.gooddata.com/hc/en-us" class="gd-docs-header-nav__menulink gd-header-link">Support</a>
-      </li>
-      <li class="gd-docs-header-nav__menuitem gd-header-link-item gd-header-link-item-mobile-only">
-        <a href="https://www.gooddata.com/" class="button">Go to GoodData.com</a>
-      </li>
-    </ul>
-  </div>
+  </nav>
+  {{ partial "header-menu.html" . }}
   {{ partial "header-right.html" . }}
-</nav>
-<nav class="gd-docs-header-nav gd-docs-header-nav__second">
-  <div class="gd-docs-header-nav__left">
-    <ul class="gd-breadcrumb">
-      <li class="gd-breadcrumb-item">
-        <a href="https://www.gooddata.com/docs/">All Products</a>
-      </li>
-      <li class="gd-breadcrumb-item">
-        <span> &nbsp;Python SDK</span>
-      </li>
-    </ul>
-  </div>
+</div>
+<div class="gd-docs-header-nav gd-docs-header-nav__second">
+  {{ partial "navbar-breadcrumb.html" . }}
   <div class="gd-docs-header-nav__center">
     <div id="adds-container" class="gd-docs-header-nav__search"></div>
   </div>
@@ -64,4 +34,4 @@
     {{ end }}
   </div>
   {{ end }}
-</nav>
+</div>