RELATED: CQ-1268 - add limits to ErrorInfo fields #1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lupko
force-pushed
the
flight-fixes
branch
3 times, most recently
from
a77ae15 to
03334da
Compare
no23reason
previously approved these changes
Apr 9, 2025
- ErrorInfo is passed as FlightError.extra_info - In turn, extra_info contents are transported via gRPC headers - gRPC headers have hard limit of 16kB size (otherwise get gRPC Resource Exhausted: initial metadata too large) - added code to truncate `msg` and `detail` if necessary. Limit for each is 1kB JIRA: CQ-1268
no23reason
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msganddetailif necessary. Limits are 256 and 512 chars respectivelly.JIRA: CQ-1268