Skip to content

fix(gooddata-sdk): cancel_executions input #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fiedlr merged 2 commits into from
Apr 28, 2025
Merged

fix(gooddata-sdk): cancel_executions input #1031

fiedlr merged 2 commits into from
Apr 28, 2025

Conversation

@fiedlr
Copy link
Contributor

@fiedlr fiedlr commented Apr 28, 2025 •
edited
Loading

Consider when doing a review

Besides the fix, gooddata-api-client has been updated (by make api-client) in the first commit, summary:

  • new input type for the cancel endpoint, this is handled by the fix
  • NotificationFilter added, this should not affect things
  • timezone is now required in gooddata-api-client/docs/AutomationSchedule.md, I'm guessing CatalogAutomationSchedule should be updated to make timezone: str instead of timezone: Optional[str]
  • pinot is removed, I didn't find any leftover code in sdk
  • starrocks was added, no change needed

@fiedlr fiedlr changed the title Afi new cancel endpoint fix(gooddata-sdk): cancel_executions input Apr 28, 2025
@fiedlr fiedlr merged commit 3d4cd5a into gooddata:master Apr 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@no23reason no23reason no23reason approved these changes

@lupko lupko Awaiting requested review from lupko lupko is a code owner

@pcerny pcerny Awaiting requested review from pcerny pcerny is a code owner

@jaceksan jaceksan Awaiting requested review from jaceksan jaceksan is a code owner

@hkad98 hkad98 Awaiting requested review from hkad98 hkad98 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fiedlr @no23reason