Skip to content

feat(cancellation): Remove obsoleted code comments #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hkad98 merged 1 commit into from
May 29, 2025
Merged

feat(cancellation): Remove obsoleted code comments #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion gooddata-sdk/gooddata_sdk/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ def __init__(
`executions_cancellable` is a flag that sets all executions computed through this client as cancellable.
In case a request for a result is interrupted, the GD server will try to free resources like killing sql queries
related to the given execution.
*This feature does not work yet, it will be rolled out soon.*
"""
self._hostname = host
self._token = token
Expand Down
2 changes: 0 additions & 2 deletions gooddata-sdk/gooddata_sdk/compute/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,6 @@ def cancel_executions(self, executions: dict[str, dict[str, str]]) -> None:
Try to cancel given executions using the cancel api endpoint.
Order of token applications is not guaranteed.

*Note that this is currently a noop, we will be enabling this functionality soon.*

Args:
executions: maps workspace_id |-> result_id_to_cancel_token_pairs
"""
Expand Down
Loading