feat: add support for polling in FlexConnect server #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no23reason
force-pushed
the
dho/cq-1124-polling-better
branch
6 times, most recently
from
e4207cb to
ee2154f
Compare
Add a polling mechanism to the FlexConnect functions so that long-running tasks can be polled for and canceled. The TaskExecutor now supports returning a timestamp of when a particular task was submitted. This is to keep track of the call deadline breaches. JIRA: CQ-1124 risk: low
Encapsulate the different invocation types so that we can change the actual representation later if needed. JIRA: CQ-1124 risk: low
When cancelling, be more transparent about whether the cancellation actually happened. Also handle missing tasks: that now yields BAD_ARGUMENT exceptions. JIRA: CQ-1124 risk: low
By default, the FlexConnect will conform to the Arrow Flight RPC spec. However, if an opt-in header is present, it will use the polling extension used by GoodData. This allows for things like query cancellation. Ideally, we would use the PollFlightInfo from the Arrow Flight RPC but unfortunately it is not yet available in PyArrow. JIRA: CQ-1124 risk: low
no23reason
force-pushed
the
dho/cq-1124-polling-better
branch
from
ee2154f to
173aa5b
Compare
no23reason
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a polling mechanism to the FlexConnect functions so that long-running tasks can be polled for and canceled.
The polling is opt-in via a call header: this is to ensure compatibility with GoodData versions that do not support this yet.
The TaskExecutor now supports returning a timestamp of when a particular task was submitted. This is to keep track of the call deadline breaches.
JIRA: CQ-1124
risk: low