feat: add on_execution_submitted to gooddata_pandas #1065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can now provide a callback that will be called with the Execution object as soon as it is available. This is useful for getting some of the information available in the Execution object before the actual data is loaded. The Execution object can also be used to cancel the execution result operation. JIRA: CQ-1387 risk: low
The ExecutionResponse is just an alias so unify the types in the file to keep things simpler. JIRA: CQ-1387 risk: low
no23reason
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Martozar
previously approved these changes
Jun 12, 2025
lupko
reviewed
Jun 12, 2025
Now that the type is Execution, the corresponding parameters should be called the same. JIRA: CQ-1387 risk: low
hkad98
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now provide a callback that will be called with the Execution object as soon as it is available. This is useful for getting some of the information available in the Execution object before the actual data is loaded. The Execution object can also be used to cancel the execution result operation.
Also unify Execution types in data_access.py: no need to use the ExecutionResponse alias anymore.
JIRA: CQ-1387
risk: low