feat: add api to gooddata-sdk for agg fact #1087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiedlr
changed the title
fiedlr
force-pushed
the
afi-cq-1236-new-preagg-dataset-endpoints
branch
4 times, most recently
from
6b2cbfb to
b367f4e
Compare
fiedlr
changed the title
fiedlr
changed the title
fiedlr
force-pushed
the
afi-cq-1236-new-preagg-dataset-endpoints
branch
5 times, most recently
from
0ea9d04 to
1d24d79
Compare
risk: low
fiedlr
force-pushed
the
afi-cq-1236-new-preagg-dataset-endpoints
branch
5 times, most recently
from
51ecebe to
45876bd
Compare
fiedlr
force-pushed
the
afi-cq-1236-new-preagg-dataset-endpoints
branch
from
45876bd to
07d03a0
Compare
fiedlr
commented
Jul 28, 2025
| if dataset.aggregated_facts: | ||
| for aggregated_fact in dataset.aggregated_facts: | ||
| if aggregated_fact.source_column: | ||
| aggregated_fact.source_column = self._change_case(aggregated_fact.source_column, upper_case) |
Contributor
Author
There was a problem hiding this comment.
Doublecheck, not sure if this should be done also for agg facts. I took it from facts
fiedlr
commented
Jul 28, 2025
| for fact in dataset.facts or []: | ||
| self.add_title_description_tags(to_translate, fact.title, fact.description, fact.tags) | ||
| for agg_fact in dataset.aggregated_facts or []: | ||
| self.add_title_description_tags(to_translate, None, agg_fact.description, agg_fact.tags) |
Contributor
Author
There was a problem hiding this comment.
Doublecheck, not sure if we should trasnlate also agg facts.
fiedlr
commented
Jul 28, 2025
| for fact in dataset.facts or []: | ||
| self.set_title_description_tags(fact, translated) | ||
| for agg_fact in dataset.aggregated_facts or []: | ||
| self.set_title_description_tags(agg_fact, translated) |
fiedlr
commented
Jul 28, 2025
| Content-Length: | ||
| - '172' | ||
| Content-Security-Policy: |
Contributor
Author
There was a problem hiding this comment.
Doublecheck - not sure why headers changed. But it should be ok as these are just mocks
Contributor
There was a problem hiding this comment.
This IMHO changed because it was run against d-c from repo and not the aio. I think it is okay.
hkad98
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the reviewer
make api-client, it's automatically generated. It could be regenerated in the rare case it would be broken