feat: Allow using credentials for AWS session #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benkeanna
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
hkad98
reviewed
Aug 12, 2025
|
|
||
| try: | ||
| return boto3.Session(profile_name=profile) | ||
| return boto3.Session(profile_name=config.profile) |
Contributor
There was a problem hiding this comment.
Profile can be None right now. What happens if everything is set to None?
benkeanna
force-pushed
the
aben/aws-credentials
branch
from
bcf065a to
1cd1fab
Compare
hkad98
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.