feat(gooddata-pipelines): Add AWS auth via IAM role #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benkeanna
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
janmatzek
reviewed
Sep 1, 2025
gooddata-pipelines/gooddata_pipelines/backup_and_restore/storage/s3_storage.py
Outdated
Show resolved
Hide resolved
benkeanna
force-pushed
the
aben/aws-iam-role
branch
6 times, most recently
from
fd9648a to
8f10053
Compare
benkeanna
force-pushed
the
aben/aws-iam-role
branch
from
8f10053 to
9b24663
Compare
janmatzek
previously approved these changes
Sep 3, 2025
janmatzek
requested changes
Sep 3, 2025
| lt=3, | ||
| description="Max workers must be greater than 0 and less than 3", | ||
| ), | ||
| ] = Field(default=ConcurrencyDefaults.MAX_WORKERS) |
Contributor
There was a problem hiding this comment.
Nitpick: You can use the BackupSettings.MAX_WORKERS, BackupSettings inherits the ConcurrencyDefaults class... although I admit that the inheritance detracts from readability here
| description="Batch size must be greater than 0", | ||
| ), | ||
| ] = Field(default=BackupSettings.DEFAULT_BATCH_SIZE) | ||
| max_workers: Annotated[ |
Contributor
There was a problem hiding this comment.
I see that the BackupManager class uses BackupSettings.MAX_WORKERS to limit the threads, not the value from BackupRestoreConfig... can you please change that in backup_manager.py?
Currently it has LN347: max_workers=BackupSettings.MAX_WORKERS which should be something like max_workers=config.max_workers
benkeanna
force-pushed
the
aben/aws-iam-role
branch
from
5836acf to
6e039ab
Compare
janmatzek
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.