Skip to content

[bot] Merge master/9f18581b into rel/dev #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yenkins-admin merged 3 commits into from
Sep 11, 2025
Merged

[bot] Merge master/9f18581b into rel/dev #1148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1803d49
docs: ensure valid links in API reference and sidebar navigation
ParzivalPavlis Sep 11, 2025
b59c506
docs: correct menu href for documentation
ParzivalPavlis Sep 11, 2025
9f18581
Merge pull request #1147 from ParzivalPavlis/docs/fix2-htmltest
hkad98 Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/layouts/partials/api-ref-link-all-partial.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
{{ $links := . }}

{{ range $name, $data := $links }}
{{ if and $data.path (ne $data.path "") }}
{{ $path := $data.path }}
{{ $kind := $data.kind }}
{{/* I don't think there is any other way to include literal backtick inside a raw-string */}}
Expand All @@ -29,6 +30,7 @@
{{ $a_html := (printf "$1<a href=\"%s/\">%s</a>$3" $path $name) }}
{{ $paragraph = replaceRE $pattern $a_html $paragraph | safeHTML}}
{{ end }}
{{ end }}
{{ end }}

{{/* Remove backticks around links */}}
Expand Down
2 changes: 1 addition & 1 deletion docs/layouts/partials/api-ref-link-partial.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
{{ $name := replace $name "List[" "" }}

{{ $data := index $links (trim $name " ") }}
{{ if $data }}
{{ if and $data $data.path (ne $data.path "") }}
{{ $path := $data.path }}
{{ $a_html := (printf "<a href=\"%s/\">%s</a>" $path $name) }}
{{ replace $orig_name $name $a_html | safeHTML}}
Expand Down
24 changes: 24 additions & 0 deletions docs/layouts/partials/header-menu.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<nav class="gd-docs-header-nav__center gd-header" aria-label="Main">
<input type="checkbox" role="button" id="gd-header-mobile-menu-trigger-input" name="gd-header-mobile-menu-trigger-input" class="gd-header-mobile gd-header-mobile-menu-trigger-input" aria-label="Open navigation menu" aria-controls="gd-header-mobile-menu" aria-expanded="false">
<label tabindex="0" for="gd-header-mobile-menu-trigger-input" class="gd-header-mobile gd-header-mobile-menu-trigger"><span></span></label>
<ul class="gd-docs-header-nav__menu gd-header-links">
<li class="gd-docs-header-nav__menuitem gd-header-link-item gd-header-link-item-mobile-only">
<a href="https://www.gooddata.com/learn/" class="gd-docs-header-nav__menulink gd-header-link gd-header-link__main">Learn</a>
</li>
<li class="gd-docs-header-nav__menuitem gd-header-link-item">
<a href="https://university.gooddata.com/" class="gd-docs-header-nav__menulink gd-header-link">University</a>
</li>
<li class="gd-docs-header-nav__menuitem gd-header-link-item">
<a href="https://community.gooddata.com/" class="gd-docs-header-nav__menulink gd-header-link">Community</a>
</li>
<li class="gd-docs-header-nav__menuitem gd-header-link-item">
<a href="https://www.gooddata.com/docs/python-sdk" class="gd-docs-header-nav__menulink gd-header-link gd-header-link__active">Documentation</a>
</li>
<li class="gd-docs-header-nav__menuitem gd-header-link-item">
<a href="https://support.gooddata.com/hc/en-us" class="gd-docs-header-nav__menulink gd-header-link">Support</a>
</li>
<li class="gd-docs-header-nav__menuitem gd-header-link-item gd-header-link-item-mobile-only">
<a href="https://www.gooddata.com/" class="button">Go to GoodData.com</a>
</li>
</ul>
</nav>
5 changes: 5 additions & 0 deletions docs/layouts/partials/navbar-version-selector.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,21 @@
{{ $.Scratch.Set "activeVersion" .version }}
{{ end }}
{{ end }}

{{ if .Site.Params.versions }}
<button class="nav-link dropdown-toggle" id="navbarDropdown" role="button" data-toggle="dropdown" data-bs-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
{{ printf "%s" ($.Scratch.Get "docLabel") }}
</button>
<div class="dropdown-menu" aria-labelledby="navbarDropdownMenuLink">
{{ range .Site.Params.versions }}
{{ if and .url (ne .url "") }}
<a
class="dropdown-item{{ if eq ( $.Scratch.Get "activeVersion" ) ( printf "%s" .version ) }} active{{ end }}"
href="{{ cond (gt (len (findRE "^http(s)?://" .url)) 0) .url (relURL .url) }}"
>
{{ .version }}
</a>
{{ end }}
{{ end }}
</div>
{{ end }}
12 changes: 9 additions & 3 deletions docs/layouts/partials/sidebar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@
<ul class="gd-docs-menu-section gd-docs-menu-section__root">
<li class="gd-docs-menu-page{{ if or $isCurrent $active }} active{{ end }}">
<div class="gd-docs-menu-page__title">
{{- if and .RelPermalink (ne .RelPermalink "") -}}
<a href="{{ .RelPermalink }}" class="gd-docs-menu-page__link">{{ .LinkTitle }}</a>
{{- else -}}
<span class="gd-docs-menu-page__link">{{ .LinkTitle }}</span>
{{- end }}
</div>
</li>
</ul>
Expand Down Expand Up @@ -49,11 +53,13 @@
<span class="gd-docs-menu-page__label">{{ $page.LinkTitle }}</span>
{{ else }}
<div class="gd-docs-menu-page__title">
{{ if $page.Params.externalLink }}
{{- if and $page.Params.externalLink (ne $page.Params.externalLink "") -}}
<a href="{{ $page.Params.externalLink }}" class="gd-docs-menu-page__link" target="_blank">{{ $page.LinkTitle }}</a>
{{ else }}
{{- else if and $page.Permalink (ne $page.Permalink "") -}}
<a href="{{ $page.Permalink }}" class="gd-docs-menu-page__link">{{ $page.LinkTitle }}</a>
{{ end }}
{{- else -}}
<span class="gd-docs-menu-page__link">{{ $page.LinkTitle }}</span>
{{- end }}

{{ if $page.Pages }}
<button
Expand Down
Loading