Skip to content

Conversation

@no23reason
Copy link
Contributor

@no23reason no23reason commented Sep 25, 2025

This is not the latest version, but a version that does not significantly change the generated types (newer versions lead to some significant renames which make the change even bigger).

Changes needed:

  • change from gooddata_api_client.model. to from gooddata_api_client.models.
  • change from gooddata_api_client import apis to from gooddata_api_client import api
  • remove _preload_content, there are now special methods with _without_preload_content suffix
  • remove _check_type and _return_http_data_only
  • replace _from with var_from for filters
  • replace OpenApiModel by BaseModel as OpenApiModel is no longer generated
  • add pydantic as a test-requirement
  • fix _create_export: the response is no longer a dict
  • fix SimpleMetric: it needs to use the Core identifier types

JIRA: CQ-1614
risk: low

@no23reason no23reason force-pushed the dho/cq-1614-generator-7_11 branch 3 times, most recently from 6f4b0e4 to fe73fce Compare September 25, 2025 09:58
This is not the latest version, but a version that does not
significantly change the generated types (newer versions lead to
some significant renames which make the change even bigger).

Changes needed:
- change `from gooddata_api_client.model.`
  to `from gooddata_api_client.models.`
- change `from gooddata_api_client import apis`
  to `from gooddata_api_client import api`
- remove `_preload_content`, there are now special methods with
  `_without_preload_content` suffix
- remove `_check_type` and `_return_http_data_only`
- replace `_from` with `var_from` for filters
- replace OpenApiModel by BaseModel as OpenApiModel is no longer
  generated
- add pydantic as a test-requirement
- fix _create_export: the response is no longer a dict
- fix SimpleMetric: it needs to use the Core identifier types

JIRA: CQ-1614
risk: low
@no23reason no23reason force-pushed the dho/cq-1614-generator-7_11 branch from fe73fce to 79f67dd Compare September 25, 2025 12:17
@no23reason
Copy link
Contributor Author

Closing as not worth the additional headache now.

@no23reason no23reason closed this Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant