feat: add new fields regarding NULL values#1277
Conversation
fiedlr
changed the title
fiedlr
force-pushed
the
afi-cq-1959-add-new-fields-to-pysdk
branch
5 times, most recently
from
df52168 to
34e13fd
Compare
fiedlr
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
fiedlr
force-pushed
the
afi-cq-1959-add-new-fields-to-pysdk
branch
6 times, most recently
from
98ad039 to
0b1f31f
Compare
fiedlr
force-pushed
the
afi-cq-1959-add-new-fields-to-pysdk
branch
11 times, most recently
from
db8c1ee to
c66c70f
Compare
There was a problem hiding this comment.
Needed to de-sync workspace refresh and workspace upload for some tests
There was a problem hiding this comment.
Is this similar to the fixture in tests-support, or is it the same? If yes, we might want to add tests-support as a test dependency to gooddata-sdk.
There was a problem hiding this comment.
Good point. Hard diffing is unfeasible, AI says they are very similar modulo order, memoryItems: [] and the isNullable fields, but one of the filters on Active Customers has a different value.
However, I would ask to let this one go because the ticket is high-priority rn and it could break things. I would do it in a followup.
There was a problem hiding this comment.
This was missing from the localization update (not related to ticket but needed)
There was a problem hiding this comment.
We left localization testing in gooddata-python-sdk/packages/gooddata-sdk/tests/catalog/expected/declarative_workspaces.json
There was a problem hiding this comment.
We add this to isolate testing stuff with locales
There was a problem hiding this comment.
This should've been in the first commit but we can keep it here
fiedlr
force-pushed
the
afi-cq-1959-add-new-fields-to-pysdk
branch
from
4e50c4e to
4ca8d2d
Compare
fiedlr
force-pushed
the
afi-cq-1959-add-new-fields-to-pysdk
branch
from
4ca8d2d to
78e31f4
Compare
| @@ -93,8 +93,9 @@ def _are_user_data_filters_empty(sdk: GoodDataSdk, workspace_id: str) -> None: | |||
|
|
|||
| @gd_vcr.use_cassette(str(_fixtures_dir / "demo_load_and_put_declarative_workspaces.yaml")) | |||
| def test_load_and_put_declarative_workspaces(test_config): | |||
| # This test includes testing locales! | |||
There was a problem hiding this comment.
Do we still have a test to test without locale?
There was a problem hiding this comment.
I faintly remember that there were tests that didn't make sense with locales, I would need to find it though. I tried to go fast.
Can we leave it like this and I would look at it in a followup?
packages/gooddata-sdk/tests/catalog/test_catalog_data_source.py
Outdated
Show resolved
Hide resolved
packages/gooddata-sdk/tests/catalog/test_catalog_data_source.py
Outdated
Show resolved
Hide resolved
jira: CQ-1959 risk: low
fiedlr
force-pushed
the
afi-cq-1959-add-new-fields-to-pysdk
branch
from
78e31f4 to
a97f055
Compare
2 participants
jira: CQ-1959
risk: low