feat(api-client): Sync P005 - datetime format schema annotations#1325
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
feat(api-client): Sync P005 - datetime format schema annotations#1325yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
Synchronize SDK with gdc-nas changes that added explicit OpenAPI datetime format schema annotations to createdAt/modifiedAt fields across 8 metadata models (AnalyticalDashboard, AttributeHierarchy, Automation, DashboardPlugin, ExportDefinition, MemoryItem, Metric, VisualizationObject). The gooddata-api-client was regenerated from updated metadata-api OpenAPI spec and now includes proper datetime type annotations and regex validation patterns (YYYY-MM-DD HH:MM format) for all affected entity models. This resolves a mismatch where the API spec indicated date-time format but the implementation returned strings without format specification. Related: STL-2296, P005 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
|
Close please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronize SDK with gdc-nas datetime format schema annotations for metadata model timestamp fields.
Jira ticket pending (sandbox under maintenance - manual creation required).
Problem P005 - Workflow: https://github.com/gooddata/gdc-nas/actions/runs/22064429506
Summary
This PR tracks the synchronization of P005 changes from gdc-nas that added explicit OpenAPI datetime format schema annotations to
createdAtandmodifiedAtfields across 8 metadata models.GDC-NAS Changes
Affected Entities
SDK Implementation
The gooddata-api-client was regenerated from the updated metadata-api OpenAPI spec and now includes:
(datetime, none_type,)r'[0-9]{4}-[0-9]{2}-[0-9]{2} [0-9]{2}:[0-9]{2}'This resolves a mismatch where the API spec indicated date-time format but the implementation returned strings without format specification.
Verification
✅ All 8 affected model files verified to contain proper datetime patterns
✅ Type annotations correctly reflect nullable datetime fields
✅ No additional SDK code changes required (API client already regenerated)
Notes
.sync-notes/P005-datetime-format.mdfor complete details