Skip to content

fix: client_id was missing from declarative data source #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chrisbonilla95 merged 1 commit into from
Nov 28, 2024
Merged

fix: client_id was missing from declarative data source #915

chrisbonilla95 merged 1 commit into from
Nov 28, 2024

Conversation

@chrisbonilla95
Copy link
Contributor

@chrisbonilla95 chrisbonilla95 commented Nov 28, 2024

Had placed client_id in the wrong place. Should be part of CatalogDeclarativeDataSource

JIRA: LX-669
risk: low

@chrisbonilla95 chrisbonilla95 merged commit 291028f into gooddata:master Nov 28, 2024
8 checks passed
@chrisbonilla95 chrisbonilla95 deleted the cbon-lx-669-declarative-datasource-fix branch November 28, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hkad98 hkad98 hkad98 approved these changes

@lupko lupko Awaiting requested review from lupko lupko is a code owner

@pcerny pcerny Awaiting requested review from pcerny pcerny is a code owner

@jaceksan jaceksan Awaiting requested review from jaceksan jaceksan is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chrisbonilla95 @hkad98