[bot] Merge master/484fc20c into rel/dev #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this was hardcoded to 60 seconds before - added new option `call_deadline_ms` - allows to configure deadline for the FlexConnection function call; in millis - if not specified, the default of 180 seconds will be used - added extra e2e test verifying the behavior - sanitized test fixtures / test function JIRA: CQ-1005
- for now, this will mainly work in cases when the task is still in the queue - once the task is running & making the function call, there is no mechanism to tell the call to cancel JIRA: CQ-1005
JIRA: CQ-1005
- see code comments for explanation JIRA: CQ-1005
RELATED: CQ-1005 - make FlexConnect function call deadline configurable
yenkins-admin
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 484fc20 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/12292394518).