Skip to content

fix: proper cred loading for Databricks pt2. #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisbonilla95 merged 1 commit into from
Feb 6, 2025
Merged

fix: proper cred loading for Databricks pt2. #971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gooddata-sdk/gooddata_sdk/catalog/data_source/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ def test_data_sources_connection(
declarative_data_source.to_test_request(token=token)
)
elif declarative_data_source.type == DATABRICKS_TYPE:
if declarative_data_source.client_id is not None:
if declarative_data_source.client_id and declarative_data_source.client_id.strip():
client_secret = ClientSecretCredentialsFromFile.client_secret_from_file(
credentials[declarative_data_source.id]
)
Expand Down
Loading