Skip to content

[bot] Merge master/ca10fe22 into rel/dev #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yenkins-admin merged 4 commits into from
Feb 6, 2025
Merged

[bot] Merge master/ca10fe22 into rel/dev #972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43e1c7e
fix: proper cred loading for Databricks
chrisbonilla95 Feb 6, 2025
ba151d2
Merge pull request #969 from chrisbonilla95/cbon-lx-691-databricks-ds…
chrisbonilla95 Feb 6, 2025
5990e79
fix: proper cred loading for Databricks pt2.
chrisbonilla95 Feb 6, 2025
ca10fe2
Merge pull request #971 from chrisbonilla95/cbon-lx-691-databricks-ds…
chrisbonilla95 Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gooddata-sdk/gooddata_sdk/catalog/data_source/declarative_model/data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def _inject_base(self, credentials: dict[str, Any]) -> DeclarativeDataSources:
token = TokenCredentialsFromFile.token_from_file(credentials[data_source.id])
data_sources.append(data_source.to_api(token=token))
elif data_source.type == DATABRICKS_TYPE:
if data_source.client_id is not None:
if data_source.client_id and data_source.client_id.strip():
client_secret = ClientSecretCredentialsFromFile.client_secret_from_file(
credentials[data_source.id]
)
Expand Down
2 changes: 1 addition & 1 deletion gooddata-sdk/gooddata_sdk/catalog/data_source/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ def test_data_sources_connection(
declarative_data_source.to_test_request(token=token)
)
elif declarative_data_source.type == DATABRICKS_TYPE:
if declarative_data_source.client_id is not None:
if declarative_data_source.client_id and declarative_data_source.client_id.strip():
client_secret = ClientSecretCredentialsFromFile.client_secret_from_file(
credentials[declarative_data_source.id]
)
Expand Down
Loading