Skip to content

[bot] Merge master/d758f105 into rel/dev #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yenkins-admin merged 2 commits into from
Feb 10, 2025
Merged

[bot] Merge master/d758f105 into rel/dev #977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a460fd1
docs: add rule to ruff to check un-documented params
hkad98 Feb 10, 2025
d758f10
Merge pull request #976 from hkad98/jkd/docs
hkad98 Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gooddata-pandas/gooddata_pandas/data_access.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ def _extract_from_attributes_and_maybe_metrics(

Args:
response (ExecutionResponse): The execution response to extract data from.
catalog (CatalogWorkspaceContent): The catalog workspace content.
attributes (list[CatalogAttribute]): The catalog of attributes.
cols (list[str]): A list of column names.
col_to_attr_idx (dict[str, int]): A mapping of pandas column names to attribute dimension indices.
col_to_metric_idx (dict[str, int]): A mapping of pandas column names to metric dimension indices.
Expand Down
6 changes: 3 additions & 3 deletions gooddata-sdk/gooddata_sdk/catalog/permission/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def get_declarative_organization_permissions(self) -> list[CatalogDeclarativeOrg
None

Returns:
[CatalogDeclarativeOrganizationPermission]:
list[CatalogDeclarativeOrganizationPermission]:
List of all declarative organization permissions.
"""

Expand All @@ -136,8 +136,8 @@ def put_declarative_organization_permissions(
"""Put a list of all declarative organization permissions.

Args:
org_permissions([CatalogDeclarativeOrganizationPermission])
list of declarative organization permissions
org_permissions (list[CatalogDeclarativeOrganizationPermission]):
List of declarative organization permissions.

Returns:
None
Expand Down
1 change: 1 addition & 0 deletions gooddata-sdk/gooddata_sdk/catalog/workspace/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,7 @@ def generate_localized_workspaces(
provision_workspace: Should new workspace for the target language be provisioned?
Including setting of corresponding locales.
store_layouts: Store declarative layouts of all workspaces to disk
place_in_hierarchy (bool): Flag if localized workspace should be placed in the hierarchy.

Returns:
None
Expand Down
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ lint.select = [
"SIM",
"UP",
"W", # pycodestyle warnings
"D417", # undocumented-param
]
lint.ignore = [
# rules recommended to be ignored when using ruff format
Expand All @@ -44,6 +45,8 @@ target-version = "py39"
[tool.ruff.format]
exclude = ['(gooddata-api-client|.*\.snapshot\..*)']

[tool.ruff.lint.pydocstyle]
convention = "google"

[tool.tbump]
# Uncomment this if your project is hosted on GitHub:
Expand Down
Loading