Skip to content

fix: support 1d vis table conversion #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tjev merged 1 commit into from
Feb 13, 2025
Merged

fix: support 1d vis table conversion #986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion gooddata-sdk/gooddata_sdk/table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,9 @@ def _as_table(response: ExecutionResponse, always_two_dimensional: bool = False)
first_page_offset = [0, 0]
first_page_limit = [_TABLE_ROW_BATCH_SIZE, _MAX_METRICS]

if not always_two_dimensional:
# always adjust paging based on presence of metrics/attrs if not always_two_dimensional
# (behavior expected in FDW), otherwise, adjust if response contains only one-dimensional data
if not always_two_dimensional or len(response.dimensions) == 1:
if not response.exec_def.has_attributes():
# there are no attributes, there shall be at most one row with the metrics, so get that as first page
first_page_limit = [first_page_limit[1]]
Expand Down
Loading