Skip to content

[bot] Merge master/c80fd373 into rel/dev #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yenkins-admin merged 2 commits into from
Feb 18, 2025
Merged

[bot] Merge master/c80fd373 into rel/dev #989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5e6734
fix: export_pdf failed without metadata
hkad98 Feb 18, 2025
c80fd37
Merge pull request #988 from hkad98/jkd/fix-pdf-export
hkad98 Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion gooddata-sdk/gooddata_sdk/catalog/export/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,10 @@ def export_pdf(
if not self._dashboard_id_exists(workspace_id, dashboard_id):
raise ValueError(f"Dashboard id '{dashboard_id}' does not exist for workspace '{workspace_id}'.")
store_path = store_path if isinstance(store_path, Path) else Path(store_path)
request = VisualExportRequest(dashboard_id=dashboard_id, file_name=file_name, metadata=metadata)
if metadata is None:
request = VisualExportRequest(dashboard_id=dashboard_id, file_name=file_name)
else:
request = VisualExportRequest(dashboard_id=dashboard_id, file_name=file_name, metadata=metadata)
file_path = store_path / f"{file_name}.pdf"
create_func = self._actions_api.create_pdf_export
get_func = self._actions_api.get_exported_file
Expand Down
Loading