Skip to content

[bot] Merge master/377dfef8 into rel/dev #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yenkins-admin merged 2 commits into from
Feb 18, 2025
Merged

[bot] Merge master/377dfef8 into rel/dev #992

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4377430
docs: add docstrings DataSourceValidator
hkad98 Feb 18, 2025
377dfef
Merge pull request #991 from hkad98/jkd/fix-docs
hkad98 Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions gooddata-sdk/gooddata_sdk/catalog/data_source/validation/data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@ def __init__(self, data_source_service: CatalogDataSourceService):
self._ds_service = data_source_service

def validate_ldm(self, model: CatalogDeclarativeModel) -> None:
"""
Validates that referenced data sources in LDM actually exist.
If they do not exist, raises ValueError.

Returns:
None
"""
if model.ldm is not None:
ldm_ds_in_use = set(
dataset.data_source_table_id.data_source_id
Expand All @@ -19,6 +26,12 @@ def validate_ldm(self, model: CatalogDeclarativeModel) -> None:
self.validate_data_source_ids(ldm_ds_in_use)

def validate_data_source_ids(self, data_source_ids: set[str]) -> None:
"""
Compares data source ids with existing data sources in the catalog.

Returns:
None
"""
full_ds_set = set(data_source.id for data_source in self._ds_service.list_data_sources())
diff_ds = data_source_ids - full_ds_set
if len(diff_ds) != 0:
Expand Down
Loading