fs: default writeSecureFile to 0600 (owner-only) #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
writeSecureFilecurrently defaults to0o640, which makes created files group-readable. since this helper is used to write credential material (directly or via downstream actions), this changes the default to0o600while keeping the ability for callers to overridemodeexplicitly.changes
writeSecureFiledefault mode to0o600modecompatibility
this is a behavior change for callers that relied on the previous default group-readable permissions. those callers can restore the old behavior by passing
mode: 0o640explicitly.testing
npm testnpm run lint\n\ncloses writeSecureFile defaults to group-readable mode (0640) #153